Skip to content

docs(turbopack): Migrate docs about traits from mdbook to rustdocs#91170

Merged
bgw merged 2 commits intocanaryfrom
bgw/turbo-tasks-traits-docs
Mar 12, 2026
Merged

docs(turbopack): Migrate docs about traits from mdbook to rustdocs#91170
bgw merged 2 commits intocanaryfrom
bgw/turbo-tasks-traits-docs

Conversation

@bgw
Copy link
Member

@bgw bgw commented Mar 10, 2026 •
edited
Loading

Migrates the content from https://turbopack-rust-docs.vercel.sh/turbo-engine/traits.html over to rustdocs, and tries to update/fix some minor mistakes our outdated docs.

Screenshot 2026-03-10 at 14-38-39 value_trait in turbo_tasks - Rust.png

Screenshot 2026-03-10 at 14-39-33 VcValueTrait in turbo_tasks - Rust.png

Screenshot 2026-03-10 at 14-39-05 VcValueType in turbo_tasks - Rust.png

@nextjs-bot nextjs-bot added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Mar 10, 2026
This was referenced Mar 10, 2026
Merged
Merged
@vercel
Copy link
Contributor

vercel bot commented Mar 10, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
v0-next-js Error Error Open in v0 Mar 10, 2026 9:45pm

This was referenced Mar 10, 2026
Merged
Merged
Merged
Merged
@bgw Graphite App
Copy link
Member Author

bgw commented Mar 10, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

vercel[bot]
vercel bot reviewed Mar 10, 2026
View reviewed changes
@bgw bgw marked this pull request as ready for review March 10, 2026 21:53
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Mar 10, 2026 •
edited
Loading

Tests Passed

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 10, 2026 •
edited
Loading

Merging this PR will not alter performance

✅ 17 untouched benchmarks
⏩ 3 skipped benchmarks1

Comparing bgw/turbo-tasks-traits-docs (9c7897d) with canary (fc6bd9e)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@bgw bgw force-pushed the bgw/turbo-tasks-traits-docs branch from e5d2176 to dd1164f Compare March 10, 2026 22:18
@bgw bgw force-pushed the bgw/turbo-tasks-task-input-docs branch from e092b40 to d38fe93 Compare March 10, 2026 22:18
@bgw bgw requested review from a team, icyJoseph and mmastrac March 10, 2026 22:18
@bgw bgw mentioned this pull request Mar 11, 2026
Merged
lukesandberg
lukesandberg reviewed Mar 11, 2026
View reviewed changes
lukesandberg
lukesandberg reviewed Mar 11, 2026
View reviewed changes
lukesandberg
lukesandberg reviewed Mar 11, 2026
View reviewed changes
lukesandberg
lukesandberg reviewed Mar 11, 2026
View reviewed changes
@bgw bgw force-pushed the bgw/turbo-tasks-task-input-docs branch from d38fe93 to 58772b2 Compare March 11, 2026 01:57
@bgw bgw force-pushed the bgw/turbo-tasks-traits-docs branch from dd1164f to 17530b3 Compare March 11, 2026 01:57
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Mar 11, 2026 •
edited
Loading

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 965ms 1.014s ✓ █▁▁▁▁
Cold (Ready in log) 928ms 981ms ✓ ▇▁▁▁▁
Cold (First Request) 1.744s 1.760s ✓ ▇▃▂▃▃
Warm (Listen) 963ms 1.014s ✓ █▁▁▁▁
Warm (Ready in log) 927ms 995ms ✓ ▇▁▁▁▁
Warm (First Request) 725ms 774ms ✓ ▇▂▁▁▂
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 455ms 455ms ✓ ▁▁▁▁▁
Cold (Ready in log) 435ms 435ms ✓ ▆█▆▆▆
Cold (First Request) 1.949s 1.941s ✓ ▃▇▄▃▄
Warm (Listen) 456ms 455ms ✓ ▁█▁▁▁
Warm (Ready in log) 434ms 433ms ✓ ▆█▆▆▆
Warm (First Request) 1.930s 1.925s ✓ ▃▅▃▃▃

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 7.090s 7.033s ✓ ▇▁▂▁▁
Cached Build 6.866s 7.100s ✓ ▆▁▂▁▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 14.089s 14.104s ✓ ▂▅▁▁▁
Cached Build 14.209s 14.199s ✓ ▁▅▁▁▁
node_modules Size 481 MB 481 MB ✓ █████
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **408 kB** → **408 kB** ✅ -9 B

80 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 771 B 761 B 🟢 10 B (-1%)
Total 771 B 761 B ✅ -10 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 450 B 450 B ✓
Total 450 B 450 B ✓

📦 Webpack

Client

Main Bundles
Canary PR Change
5528-HASH.js gzip 5.54 kB N/A -
6280-HASH.js gzip 59.6 kB N/A -
6335.HASH.js gzip 169 B N/A -
912-HASH.js gzip 4.59 kB N/A -
e8aec2e4-HASH.js gzip 62.6 kB N/A -
framework-HASH.js gzip 59.7 kB 59.7 kB ✓
main-app-HASH.js gzip 256 B 252 B 🟢 4 B (-2%)
main-HASH.js gzip 39.2 kB 39.2 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
262-HASH.js gzip N/A 4.59 kB -
2889.HASH.js gzip N/A 169 B -
5602-HASH.js gzip N/A 5.55 kB -
6948ada0-HASH.js gzip N/A 62.6 kB -
9544-HASH.js gzip N/A 60.4 kB -
Total 233 kB 234 kB ⚠️ +728 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 194 B ✓
_error-HASH.js gzip 183 B 180 B 🟢 3 B (-2%)
css-HASH.js gzip 331 B 330 B ✓
dynamic-HASH.js gzip 1.81 kB 1.81 kB ✓
edge-ssr-HASH.js gzip 256 B 256 B ✓
head-HASH.js gzip 351 B 352 B ✓
hooks-HASH.js gzip 384 B 383 B ✓
image-HASH.js gzip 580 B 581 B ✓
index-HASH.js gzip 260 B 260 B ✓
link-HASH.js gzip 2.51 kB 2.51 kB ✓
routerDirect..HASH.js gzip 320 B 319 B ✓
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 315 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.98 kB 7.98 kB ✅ -1 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 125 kB 125 kB ✓
page.js gzip 266 kB 266 kB ✓
Total 391 kB 391 kB ⚠️ +135 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 617 B 615 B ✓
middleware-r..fest.js gzip 156 B 155 B ✓
middleware.js gzip 43.8 kB 43.7 kB ✓
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 45.4 kB 45.3 kB ✅ -94 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 715 B 718 B ✓
Total 715 B 718 B ⚠️ +3 B
Build Cache
Canary PR Change
0.pack gzip 4.19 MB 4.19 MB 🟢 4.41 kB (0%)
index.pack gzip 108 kB 108 kB ✓
index.pack.old gzip 107 kB 108 kB ✓
Total 4.41 MB 4.41 MB ✅ -3.86 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 331 kB 331 kB ✓
app-page-exp..prod.js gzip 179 kB 179 kB ✓
app-page-tur...dev.js gzip 331 kB 331 kB ✓
app-page-tur..prod.js gzip 179 kB 179 kB ✓
app-page-tur...dev.js gzip 327 kB 327 kB ✓
app-page-tur..prod.js gzip 177 kB 177 kB ✓
app-page.run...dev.js gzip 328 kB 328 kB ✓
app-page.run..prod.js gzip 177 kB 177 kB ✓
app-route-ex...dev.js gzip 75.9 kB 75.9 kB ✓
app-route-ex..prod.js gzip 51.6 kB 51.6 kB ✓
app-route-tu...dev.js gzip 75.9 kB 75.9 kB ✓
app-route-tu..prod.js gzip 51.6 kB 51.6 kB ✓
app-route-tu...dev.js gzip 75.5 kB 75.5 kB ✓
app-route-tu..prod.js gzip 51.4 kB 51.4 kB ✓
app-route.ru...dev.js gzip 75.5 kB 75.5 kB ✓
app-route.ru..prod.js gzip 51.4 kB 51.4 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 43.3 kB 43.3 kB ✓
pages-api-tu..prod.js gzip 32.9 kB 32.9 kB ✓
pages-api.ru...dev.js gzip 43.2 kB 43.2 kB ✓
pages-api.ru..prod.js gzip 32.9 kB 32.9 kB ✓
pages-turbo....dev.js gzip 52.6 kB 52.6 kB ✓
pages-turbo...prod.js gzip 38.5 kB 38.5 kB ✓
pages.runtim...dev.js gzip 52.6 kB 52.6 kB ✓
pages.runtim..prod.js gzip 38.5 kB 38.5 kB ✓
server.runti..prod.js gzip 62.4 kB 62.4 kB ✓
Total 2.94 MB 2.94 MB ✅ -1 B
📎 Tarball URL 
https://vercel-packages.vercel.app/next/commits/9c7897dfcaf1ce441a4837ab3bde39ea141051ce/next

@bgw bgw force-pushed the bgw/turbo-tasks-task-input-docs branch from 58772b2 to dfc69dd Compare March 11, 2026 21:51
@bgw bgw force-pushed the bgw/turbo-tasks-traits-docs branch from 17530b3 to c2ed84c Compare March 11, 2026 21:51
@bgw bgw mentioned this pull request Mar 11, 2026
Merged
@bgw bgw force-pushed the bgw/turbo-tasks-task-input-docs branch from dfc69dd to 72bc972 Compare March 11, 2026 22:23
@bgw bgw force-pushed the bgw/turbo-tasks-traits-docs branch from c2ed84c to 5772998 Compare March 11, 2026 22:24
@graphite-app graphite-app bot changed the base branch from bgw/turbo-tasks-task-input-docs to graphite-base/91170 March 12, 2026 15:54
@bgw bgw force-pushed the graphite-base/91170 branch from 72bc972 to fc6bd9e Compare March 12, 2026 18:42
@bgw bgw force-pushed the bgw/turbo-tasks-traits-docs branch from 5772998 to d1b699a Compare March 12, 2026 18:42
@graphite-app graphite-app bot changed the base branch from graphite-base/91170 to canary March 12, 2026 18:43
@bgw bgw force-pushed the bgw/turbo-tasks-traits-docs branch from d1b699a to 9c7897d Compare March 12, 2026 18:43
@bgw bgw merged commit 0b5f67d into canary Mar 12, 2026
289 of 292 checks passed
@bgw Graphite App
Copy link
Member Author

bgw commented Mar 12, 2026

Merge activity

  • Mar 12, 10:47 PM UTC: @bgw merged this pull request with Graphite.

@bgw bgw deleted the bgw/turbo-tasks-traits-docs branch March 12, 2026 22:47
ijjk pushed a commit that referenced this pull request Mar 13, 2026
@bgw @ijjk
docs(turbopack): Migrate docs about traits from mdbook to rustdocs (#…
277b58a 
…91170)

Migrates the content from https://turbopack-rust-docs.vercel.sh/turbo-engine/traits.html over to rustdocs, and tries to update/fix some minor mistakes our outdated docs.

![Screenshot 2026-03-10 at 14-38-39 value_trait in turbo_tasks - Rust.png](https://app.graphite.com/user-attachments/assets/5cc9c7d1-6260-45a9-8898-a5fdb85a5dc0.png)

![Screenshot 2026-03-10 at 14-39-33 VcValueTrait in turbo_tasks - Rust.png](https://app.graphite.com/user-attachments/assets/24448df5-8745-4568-82f1-294272e4417f.png)

![Screenshot 2026-03-10 at 14-39-05 VcValueType in turbo_tasks - Rust.png](https://app.graphite.com/user-attachments/assets/01ea2e00-7d7f-4759-b44f-e75a2a7fba9d.png)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vercel vercel[bot] vercel[bot] left review comments

@lukesandberg lukesandberg lukesandberg approved these changes

@mmastrac mmastrac mmastrac approved these changes

@icyJoseph icyJoseph Awaiting requested review from icyJoseph

Assignees

No one assigned

Labels

created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bgw @nextjs-bot @lukesandberg @mmastrac